AshinGau commented on code in PR #17298:
URL: https://github.com/apache/doris/pull/17298#discussion_r1124071163
##########
be/src/runtime/types.cpp:
##########
@@ -264,9 +264,9 @@ TypeDescriptor::TypeDescriptor(const
google::protobuf::RepeatedPtrField<PTypeNod
}
}
-void TypeDescriptor::add_sub_type(TypeDescriptor&& sub_type, bool&&
is_nullable) {
- children.emplace_back(sub_type);
- contains_nulls.emplace_back(is_nullable);
+void TypeDescriptor::add_sub_type(TypeDescriptor sub_type, bool is_nullable) {
Review Comment:
OK, it looks well. How about another polymorphic function
`add_sub_type(TypeDescriptor&& sub_type, std::string&& field_name, bool&&
is_nullable)`? It feels strange that the parameter forms of the two functions
are not uniform.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
