[GitHub] [doris] ZhangYu0123 commented on a diff in pull request #17331: [Fix](Lightweight schema Change) query error caused by array default type is unsupported

Fri, 03 Mar 2023 07:53:23 -0800 


ZhangYu0123 commented on code in PR #17331:
URL: https://github.com/apache/doris/pull/17331#discussion_r1124650356


##########
be/src/olap/rowset/segment_v2/column_reader.cpp:
##########
@@ -1186,14 +1204,20 @@ void 
DefaultValueColumnIterator::insert_default_data(const TypeInfo* type_info,
     case OLAP_FIELD_TYPE_VARCHAR:
     case OLAP_FIELD_TYPE_CHAR:
     case OLAP_FIELD_TYPE_JSONB: {
-        data_ptr = ((Slice*)mem_value)->data;
-        data_len = ((Slice*)mem_value)->size;
+        char* data_ptr = ((Slice*)mem_value)->data;
+        size_t data_len = ((Slice*)mem_value)->size;
         dst->insert_many_data(data_ptr, data_len, n);
         break;
     }
+    case OLAP_FIELD_TYPE_ARRAY: {
+        for (int i = 0; i < n; i++) {
+            dst->insert(doris::vectorized::Array(0));

Review Comment:
   Because  columnNullable will make null value as default.   So  in this 
function is used to process the default  value  situation.   
   
![image](https://user-images.githubusercontent.com/67053339/222765649-419fe6fd-24e6-419b-9958-997a41088465.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to