[GitHub] [doris] xiaokang commented on a diff in pull request #17344: [feature](function) support type template in SQL function

Sat, 04 Mar 2023 21:27:35 -0800 


xiaokang commented on code in PR #17344:
URL: https://github.com/apache/doris/pull/17344#discussion_r1125600558


##########
gensrc/script/doris_builtins_functions.py:
##########
@@ -100,7 +104,7 @@
     [['element_at', '%element_extract%'], 'STRING', ['ARRAY_STRING', 
'BIGINT'], 'ALWAYS_NULLABLE'],
 
     # map element
-    [['element_at', '%element_extract%'], 'INT', ['MAP_STRING_INT', 'STRING'], 
'ALWAYS_NULLABLE'],
+    [['element_at', '%element_extract%'], 'V', ['MAP<K, V>', 'K'], 
'ALWAYS_NULLABLE', ['K', 'V']],
 

Review Comment:
   yes, only one is need for each array function. You should add [‘K’] in the 
last entry to specify which types are template type, just like C++ template 
declaration.
   
   `[['array_sort'], 'ARRAY<K>',   ['ARRAY<K>'], '', ['K']]`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to