zddr commented on code in PR #17455:
URL: https://github.com/apache/doris/pull/17455#discussion_r1127302067
##########
fe/fe-core/src/main/java/org/apache/doris/common/proc/FrontendsProcNode.java:
##########
@@ -142,7 +141,10 @@ public static void getFrontendsInfo(Env env,
List<List<String>> infos) {
}
private static boolean isHelperNode(List<HostInfo> helperNodes, Frontend
fe) {
- return helperNodes.stream().anyMatch(p -> p.getIp().equals(fe.getIp())
&& p.getPort() == fe.getEditLogPort());
+ return helperNodes.stream().anyMatch(p ->
+ p.getPort() == fe.getEditLogPort()
+ && (p.getIp().equals(fe.getIp())
+ || (!Strings.isNullOrEmpty(p.getHostName()) &&
p.getHostName().equals(fe.getHostName()))));
Review Comment:
can we transfer Frontend to HostInfo,and than use HostInfo.isSame(HostInfo
other) to compare if equals?Otherwise, it may be difficult to maintain in the
future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
