stalary commented on code in PR #17412:
URL: https://github.com/apache/doris/pull/17412#discussion_r1128827344
##########
docker/thirdparties/custom_settings.env:
##########
@@ -20,4 +20,4 @@
# Do not use "_" or other sepcial characters, only number and alphabeta.
# eg: CONTAINER_UID="doris-jack-"
# NOTICE: change this uid will modify the file in docker-compose.
-CONTAINER_UID="doris--"
+CONTAINER_UID="doris-a-"
Review Comment:
Why modify it
##########
fe/fe-core/src/main/java/org/apache/doris/external/elasticsearch/EsUtil.java:
##########
@@ -108,22 +108,26 @@ public static ObjectNode getRootSchema(ObjectNode
mappings, String mappingType)
// 3. Equal 6.8.x and before user not passed
if (mappingType == null) {
// remove dynamic templates, for ES 7.x and 8.x
- checkNonPropertiesFields(mappings);
- String firstType = mappings.fieldNames().next();
- if (!"properties".equals(firstType)) {
- // If type is not passed in takes the first type.
- ObjectNode firstData = (ObjectNode) mappings.get(firstType);
- // check for ES 6.x and before
- checkNonPropertiesFields(firstData);
- return firstData;
+ // checkNonPropertiesFields(mappings);
Review Comment:
Can rebase master
##########
regression-test/conf/regression-conf.groovy:
##########
@@ -86,7 +86,7 @@ hdfs_port=8120
// elasticsearch catalog test config
// See `docker/thirdparties/start-thirdparties-docker.sh`
-enableEsTest=false
+enableEsTest=true
Review Comment:
CI not enable it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
