zhannngchen commented on code in PR #17617:
URL: https://github.com/apache/doris/pull/17617#discussion_r1130827357
##########
be/src/olap/tablet.cpp:
##########
@@ -2590,7 +2590,8 @@ Status Tablet::update_delete_bitmap_without_lock(const
RowsetSharedPtr& rowset)
return Status::OK();
}
-Status Tablet::update_delete_bitmap(const RowsetSharedPtr& rowset, const
TabletTxnInfo* load_info) {
+Status Tablet::update_delete_bitmap(const RowsetSharedPtr& rowset, const
TabletTxnInfo* load_info,
+ bool need_recalc_delete_bitmap) {
Review Comment:
Don't need to add an extra parameter, just set load_info->num_keys=-1, and
only check correctness when num_keys >=0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
