lexluo09 commented on code in PR #17608:
URL: https://github.com/apache/doris/pull/17608#discussion_r1133271359
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -2161,6 +2176,12 @@ public long saveMTMVJobManager(CountingDataOutputStream
out, long checksum) thro
return checksum;
}
+ public long saveGlobalFunction(CountingDataOutputStream out, long
checksum) throws IOException {
+ Env.getCurrentEnv().getGlobalFunctionMgr().write(out);
Review Comment:
Yes, thank you for your advice.
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -4811,8 +4832,13 @@ public void replayTruncateTable(TruncateTableInfo info)
throws MetaNotFoundExcep
public void createFunction(CreateFunctionStmt stmt) throws UserException {
FunctionName name = stmt.getFunctionName();
- Database db = getInternalCatalog().getDbOrDdlException(name.getDb());
- db.addFunction(stmt.getFunction(), stmt.isIfNotExists());
+ InternalCatalog internalCatalog = getInternalCatalog();
Review Comment:
Yes, thank you for your advice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
