This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 6386458498 [Refactor](exec) remove unless attr of slot ref (#17688)
6386458498 is described below
commit 6386458498b94397f684d18d31277649571ae97a
Author: HappenLee <[email protected]>
AuthorDate: Sun Mar 12 23:45:32 2023 +0800
[Refactor](exec) remove unless attr of slot ref (#17688)
Remove unless attr of slot ref
---
be/src/vec/exprs/vslot_ref.cpp | 9 +--------
be/src/vec/exprs/vslot_ref.h | 2 --
2 files changed, 1 insertion(+), 10 deletions(-)
diff --git a/be/src/vec/exprs/vslot_ref.cpp b/be/src/vec/exprs/vslot_ref.cpp
index 2ee1ba3f3e..97645fb53d 100644
--- a/be/src/vec/exprs/vslot_ref.cpp
+++ b/be/src/vec/exprs/vslot_ref.cpp
@@ -24,19 +24,12 @@
namespace doris::vectorized {
VSlotRef::VSlotRef(const doris::TExprNode& node)
- : VExpr(node), _slot_id(node.slot_ref.slot_id), _column_id(-1),
_column_name(nullptr) {
- if (node.__isset.is_nullable) {
- _is_nullable = node.is_nullable;
- } else {
- _is_nullable = true;
- }
-}
+ : VExpr(node), _slot_id(node.slot_ref.slot_id), _column_id(-1),
_column_name(nullptr) {}
VSlotRef::VSlotRef(const SlotDescriptor* desc)
: VExpr(desc->type(), true, desc->is_nullable()),
_slot_id(desc->id()),
_column_id(-1),
- _is_nullable(desc->is_nullable()),
_column_name(nullptr) {}
Status VSlotRef::prepare(doris::RuntimeState* state, const
doris::RowDescriptor& desc,
diff --git a/be/src/vec/exprs/vslot_ref.h b/be/src/vec/exprs/vslot_ref.h
index e6cf493306..50d9d24ece 100644
--- a/be/src/vec/exprs/vslot_ref.h
+++ b/be/src/vec/exprs/vslot_ref.h
@@ -44,10 +44,8 @@ public:
int slot_id() const { return _slot_id; }
private:
- FunctionPtr _function;
int _slot_id;
int _column_id;
- bool _is_nullable;
const std::string* _column_name;
};
} // namespace vectorized
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
