This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-1.2-lts
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-1.2-lts by this push:
new 24165d989c [enhancement](feservice) catch throwable and print log for
frontend service (#17708)
24165d989c is described below
commit 24165d989c145d3249e825f02fca61e9c4a62cbc
Author: yiguolei <[email protected]>
AuthorDate: Mon Mar 13 11:27:00 2023 +0800
[enhancement](feservice) catch throwable and print log for frontend service
(#17708)
---------
Co-authored-by: yiguolei <[email protected]>
---
.../main/java/org/apache/doris/service/FeServer.java | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/service/FeServer.java
b/fe/fe-core/src/main/java/org/apache/doris/service/FeServer.java
index dd7b203833..11b224df02 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/service/FeServer.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/service/FeServer.java
@@ -43,6 +43,7 @@ public class FeServer {
public void start() throws IOException {
FrontendServiceImpl service = new
FrontendServiceImpl(ExecuteEnv.getInstance());
+ Logger feServiceLogger =
LogManager.getLogger(FrontendServiceImpl.class);
FrontendService.Iface instance = (FrontendService.Iface)
Proxy.newProxyInstance(
FrontendServiceImpl.class.getClassLoader(),
FrontendServiceImpl.class.getInterfaces(),
@@ -50,9 +51,19 @@ public class FeServer {
long begin = System.currentTimeMillis();
String name = method.getName();
MetricRepo.THRIFT_COUNTER_RPC_ALL.getOrAdd(name).increase(1L);
- Object r = method.invoke(service, args);
- long end = System.currentTimeMillis();
-
MetricRepo.THRIFT_COUNTER_RPC_LATENCY.getOrAdd(name).increase(end - begin);
+ feServiceLogger.debug("receive request for {}", name);
+ Object r = null;
+ try {
+ r = method.invoke(service, args);
+ } catch (Throwable t) {
+ feServiceLogger.warn("errors while process request for
{}", name, t);
+ // If exception occurs, do not deal it, just keep as
the previous
+ throw t;
+ } finally {
+ feServiceLogger.debug("finish process request for {}",
name);
+ long end = System.currentTimeMillis();
+
MetricRepo.THRIFT_COUNTER_RPC_LATENCY.getOrAdd(name).increase(end - begin);
+ }
return r;
});
// setup frontend server
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
