englefly commented on code in PR #17757:
URL: https://github.com/apache/doris/pull/17757#discussion_r1134754351
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/FunctionBinder.java:
##########
@@ -95,7 +96,14 @@ public Expression visitUnboundFunction(UnboundFunction
unboundFunction, Cascades
FunctionBuilder builder =
functionRegistry.findFunctionBuilder(functionName, arguments);
BoundFunction boundFunction = builder.build(functionName, arguments);
- return TypeCoercionUtils.processBoundFunction(boundFunction);
+ Expression expression =
TypeCoercionUtils.processBoundFunction(boundFunction);
+ if (((BoundFunction)
expression).getName().toUpperCase().equals("SUBSTRING")) {
Review Comment:
it is better to do the part inside Substring class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
