zxealous commented on code in PR #17586:
URL: https://github.com/apache/doris/pull/17586#discussion_r1135085701
##########
be/src/io/fs/buffered_reader.cpp:
##########
@@ -67,8 +68,7 @@ Status BufferedFileStreamReader::read_bytes(const uint8_t**
buf, uint64_t offset
while (has_read < to_read) {
size_t loop_read = 0;
Slice resutl(_buf.get() + buf_remaining + has_read, to_read -
has_read);
- IOContext io_context;
- RETURN_IF_ERROR(_file->read_at(_buf_end_offset + has_read, resutl,
io_context, &loop_read));
+ RETURN_IF_ERROR(_file->read_at(_buf_end_offset + has_read, resutl,
&loop_read));
Review Comment:
Why not pass IOContext to function read_at()? I understand that we use func
BufferedFileStreamReader::read_ bytes() to read data, may be we can save
IOContext to BufferedFileStreamReader when calling ScalarColumnReader:: init
method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
