github-actions[bot] commented on code in PR #17867:
URL: https://github.com/apache/doris/pull/17867#discussion_r1138727043
##########
be/src/vec/columns/column_array.cpp:
##########
@@ -238,11 +238,12 @@ StringRef ColumnArray::serialize_value_into_arena(size_t
n, Arena& arena,
return res;
}
-const char* ColumnArray::deserialize_and_insert_from_arena(const char* pos) {
+const char* ColumnArray::deserialize_and_insert_from_arena(const char* pos,
size_t sz) {
size_t array_size = unaligned_load<size_t>(pos);
pos += sizeof(array_size);
- for (size_t i = 0; i < array_size; ++i) pos =
get_data().deserialize_and_insert_from_arena(pos);
+ for (size_t i = 0; i < array_size; ++i)
+ pos = get_data().deserialize_and_insert_from_arena(pos, sz);
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
for (size_t i = 0; i < array_size; ++i) {
pos = get_data().deserialize_and_insert_from_arena(pos, sz);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
