HappenLee commented on code in PR #17970:
URL: https://github.com/apache/doris/pull/17970#discussion_r1142209406
##########
be/src/vec/functions/array/function_array_binary.h:
##########
@@ -51,26 +53,24 @@ class FunctionArrayBinary : public IFunction {
Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
size_t result, size_t input_rows_count) override {
- auto left_column =
-
block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
- auto right_column =
-
block.get_by_position(arguments[1]).column->convert_to_full_column_if_const();
- Status ret = Status::RuntimeError(
- fmt::format("execute failed, unsupported types for function
{}({}, {})", get_name(),
-
block.get_by_position(arguments[0]).type->get_name(),
-
block.get_by_position(arguments[1]).type->get_name()));
+ auto left_column =
unpack_if_const(block.get_by_position(arguments[0]).column);
Review Comment:
const auto &
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
