github-actions[bot] commented on code in PR #17986:
URL: https://github.com/apache/doris/pull/17986#discussion_r1142964897
##########
be/src/olap/task/engine_publish_version_task.cpp:
##########
@@ -183,9 +183,13 @@ Status EnginePublishVersionTask::finish() {
}
}
- LOG(INFO) << "finish to publish version on transaction."
- << "transaction_id=" << transaction_id << ", cost(us): " <<
watch.get_elapse_time_us()
- << ", error_tablet_size=" << _error_tablet_ids->size() << ",
res=" << res.to_string();
+ if (!status.is<PUBLISH_VERSION_NOT_CONTINUOUS>()) {
Review Comment:
warning: use of undeclared identifier 'status' [clang-diagnostic-error]
```cpp
if (!status.is<PUBLISH_VERSION_NOT_CONTINUOUS>()) {
^
```
##########
be/src/olap/txn_manager.cpp:
##########
@@ -310,7 +310,7 @@ Status TxnManager::publish_txn(OlapMeta* meta, TPartitionId
partition_id,
if (load_itr != it->second.end()) {
// found load for txn,tablet
// case 1: user commit rowset, then the load id must be
equal
- load_info = &load_itr->second;
+ load_info = load_itr->second;
rowset_ptr = load_info->rowset;
Review Comment:
warning: member reference type 'doris::TabletTxnInfo' is not a pointer; did
you mean to use '.'? [clang-diagnostic-error]
```suggestion
rowset_ptr = load_info.rowset;
```
##########
be/src/olap/task/engine_publish_version_task.cpp:
##########
@@ -183,9 +183,13 @@
}
}
- LOG(INFO) << "finish to publish version on transaction."
- << "transaction_id=" << transaction_id << ", cost(us): " <<
watch.get_elapse_time_us()
- << ", error_tablet_size=" << _error_tablet_ids->size() << ",
res=" << res.to_string();
+ if (!status.is<PUBLISH_VERSION_NOT_CONTINUOUS>()) {
Review Comment:
warning: missing 'template' keyword prior to dependent template name 'is'
[clang-diagnostic-error]
```cpp
if (!status.is<PUBLISH_VERSION_NOT_CONTINUOUS>()) {
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
