morningman commented on code in PR #18013:
URL: https://github.com/apache/doris/pull/18013#discussion_r1144323904
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/ExternalFileScanNode.java:
##########
@@ -293,6 +296,17 @@ private void initHMSExternalTable(HMSExternalTable
hmsTable) throws UserExceptio
scanProvider = new IcebergScanProvider(hmsSource, analyzer);
break;
case HIVE:
+ String inputFormat =
hmsTable.getRemoteTable().getSd().getInputFormat();
+ if (inputFormat.contains("TextInputFormat")) {
+ for (SlotDescriptor slot : desc.getSlots()) {
+ if (slot.getType() instanceof ArrayType
Review Comment:
use `slot.getType().isScalarType()`
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/ExternalFileScanNode.java:
##########
@@ -293,6 +296,17 @@ private void initHMSExternalTable(HMSExternalTable
hmsTable) throws UserExceptio
scanProvider = new IcebergScanProvider(hmsSource, analyzer);
break;
case HIVE:
+ String inputFormat =
hmsTable.getRemoteTable().getSd().getInputFormat();
+ if (inputFormat.contains("TextInputFormat")) {
+ for (SlotDescriptor slot : desc.getSlots()) {
+ if (slot.getType() instanceof ArrayType
+ || slot.getType() instanceof MapType
+ || slot.getType() instanceof StructType) {
+ throw new UserException("The column types
ARRAY/MAP/STRUCT are not supported yet"
Review Comment:
show the column name in error log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
