HappenLee commented on code in PR #17999:
URL: https://github.com/apache/doris/pull/17999#discussion_r1144451012


##########
be/src/vec/exec/scan/new_olap_scan_node.cpp:
##########
@@ -398,11 +397,10 @@ Status 
NewOlapScanNode::_init_scanners(std::list<VScanner*>* scanners) {
     }
 
     // ranges constructed from scan keys
-    std::vector<std::unique_ptr<doris::OlapScanRange>> cond_ranges;
-    RETURN_IF_ERROR(_scan_keys.get_key_range(&cond_ranges));
+    RETURN_IF_ERROR(_scan_keys.get_key_range(&_cond_ranges));

Review Comment:
   init function will use the mem variable in scanner init(), so it should not 
be a tmp variable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to