github-actions[bot] commented on code in PR #17820:
URL: https://github.com/apache/doris/pull/17820#discussion_r1147452797


##########
be/src/olap/memtable.h:
##########
@@ -48,7 +49,8 @@ class MemTable {
 
     int64_t tablet_id() const { return _tablet->tablet_id(); }
     size_t memory_usage() const {
-        return _insert_mem_tracker->consumption() + 
_flush_mem_tracker->consumption();
+        return _insert_mem_tracker->consumption() + _arena->allocated_size() +

Review Comment:
   warning: no member named 'allocated_size' in 'doris::vectorized::Arena' 
[clang-diagnostic-error]
   ```cpp
           return _insert_mem_tracker->consumption() + _arena->allocated_size() 
+
                                                               ^
   ```
   



##########
be/src/olap/rowset/segment_v2/binary_dict_page.cpp:
##########
@@ -152,7 +151,7 @@ size_t BinaryDictPageBuilder::count() const {
 }
 
 uint64_t BinaryDictPageBuilder::size() const {
-    return _pool.total_allocated_bytes() + _data_page_builder->size();
+    return _arena.allocated_size() + _data_page_builder->size();

Review Comment:
   warning: no member named 'allocated_size' in 'doris::vectorized::Arena' 
[clang-diagnostic-error]
   ```cpp
       return _arena.allocated_size() + _data_page_builder->size();
                     ^
   ```
   



##########
be/src/olap/rowset/segment_v2/bitmap_index_writer.cpp:
##########
@@ -169,7 +169,7 @@ class BitmapIndexWriterImpl : public BitmapIndexWriter {
         size += _null_bitmap.getSizeInBytes(false);
         size += _reverted_index_size;
         size += _mem_index.size() * sizeof(CppType);
-        size += _pool.total_allocated_bytes();
+        size += _arena.allocated_size();

Review Comment:
   warning: no member named 'allocated_size' in 'doris::vectorized::Arena' 
[clang-diagnostic-error]
   ```cpp
           size += _arena.allocated_size();
                          ^
   ```
   



##########
be/src/olap/rowset/segment_v2/bloom_filter_index_writer.cpp:
##########
@@ -144,7 +142,7 @@ class BloomFilterIndexWriterImpl : public 
BloomFilterIndexWriter {
 
     uint64_t size() override {
         uint64_t total_size = _bf_buffer_size;
-        total_size += _pool.total_allocated_bytes();
+        total_size += _arena.allocated_size();

Review Comment:
   warning: no member named 'allocated_size' in 'doris::vectorized::Arena' 
[clang-diagnostic-error]
   ```cpp
           total_size += _arena.allocated_size();
                                ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to