morningman commented on code in PR #18059:
URL: https://github.com/apache/doris/pull/18059#discussion_r1147805826
##########
fe/fe-core/src/main/java/org/apache/doris/load/loadv2/MysqlLoadManager.java:
##########
@@ -124,20 +157,22 @@ public LoadJobRowResult
executeMySqlLoadJobFromStmt(ConnectContext context, Load
context.setExecTimeout(newTimeOut);
}
String token = tokenManager.acquireToken();
+ boolean clientLocal = dataDesc.isClientLocal();
+ MySqlLoadContext loadContext = new MySqlLoadContext();
+ loadContextMap.put(loadId, loadContext);
LOG.info("execute MySqlLoadJob for id: {}.", loadId);
try (final CloseableHttpClient httpclient =
HttpClients.createDefault()) {
for (String file : filePaths) {
- InputStreamEntity entity = getInputStreamEntity(context,
dataDesc.isClientLocal(), file, loadId);
+ InputStreamEntity entity = getInputStreamEntity(context,
clientLocal, file, loadId);
HttpPut request = generateRequestForMySqlLoad(entity,
dataDesc, database, table, token);
- MySqlLoadContext loadContext = new MySqlLoadContext();
loadContext.setRequest(request);
- loadContextMap.put(loadId, loadContext);
try (final CloseableHttpResponse response =
httpclient.execute(request)) {
String body = EntityUtils.toString(response.getEntity());
JsonObject result =
JsonParser.parseString(body).getAsJsonObject();
if
(!result.get("Status").getAsString().equalsIgnoreCase("Success")) {
+ failedRecords.offer(new MySqlLoadFailRecord(loadId,
result.get("ErrorURL").getAsString()));
LOG.warn("Execute mysql data load failed with request:
{} and response: {}", request, body);
- throw new
LoadException(result.get("Message").getAsString());
+ throw new
LoadException(result.get("Message").getAsString() + " with load id " + loadId);
Review Comment:
Why not just return the error url to user?
so that you don't need to save the `MySqlLoadFailRecord` in memory at all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
