yiguolei commented on code in PR #18075:
URL: https://github.com/apache/doris/pull/18075#discussion_r1148471163


##########
be/src/vec/common/allocator.h:
##########
@@ -120,6 +120,43 @@ static constexpr size_t MALLOC_MIN_ALIGNMENT = 8;
         }                                                           \
     } while (0)
 
+#define SYS_MEMORY_CHECK(size)                                                 
                    \

Review Comment:
   This should be a method. Not a macro.
   Should avoid use macro if it is possible because the code is not easy to 
read.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to