This is an automated email from the ASF dual-hosted git repository.

yiguolei pushed a commit to branch branch-1.2-lts
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/branch-1.2-lts by this push:
     new bb0a4eeeb8 [bugfix](buffercontrolblock) many query becomes very slow 
in 1.2.3 (#18229)
bb0a4eeeb8 is described below

commit bb0a4eeeb81aca5d01005d71a0461eee2ca26133
Author: yiguolei <[email protected]>
AuthorDate: Thu Mar 30 08:54:38 2023 +0800

    [bugfix](buffercontrolblock) many query becomes very slow in 1.2.3 (#18229)
    
    predicate in wait for is wrong, should not check is cancelled.
    
                VDataBufferSender  
(dst_fragment_instance_id=-39f306bf41e3bafb--5dc95f12d4afdcdb):
                      -  AppendBatchTime:  7s50ms
                          -  ResultRendTime:  7s5ms
                          -  TupleConvertTime:  41.829ms
                      -  NumSentRows:  38.114K  (38114)
    Co-authored-by: yiguolei <[email protected]>
---
 be/src/runtime/buffer_control_block.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/be/src/runtime/buffer_control_block.cpp 
b/be/src/runtime/buffer_control_block.cpp
index e39acd828f..f4171f7fd1 100644
--- a/be/src/runtime/buffer_control_block.cpp
+++ b/be/src/runtime/buffer_control_block.cpp
@@ -105,7 +105,7 @@ Status 
BufferControlBlock::add_batch(std::unique_ptr<TFetchDataResult>& result)
     int num_rows = result->result_batch.rows.size();
 
     while ((!_batch_queue.empty() && (num_rows + _buffer_rows) > 
_buffer_limit) && !_is_cancelled) {
-        _data_removal.wait_for(l, std::chrono::seconds(1), [&]() { return 
_is_cancelled.load(); });
+        _data_removal.wait_for(l, std::chrono::seconds(1));
     }
 
     if (_is_cancelled) {


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to