This is an automated email from the ASF dual-hosted git repository.
jakevin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 3d2c70f75d [fix](Nereids): fix merge_group(). (#18250)
3d2c70f75d is described below
commit 3d2c70f75d9e262a80e74945aee03d541bd8fc87
Author: jakevin <[email protected]>
AuthorDate: Thu Mar 30 20:34:47 2023 +0800
[fix](Nereids): fix merge_group(). (#18250)
---
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/Memo.java | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/memo/Memo.java
b/fe/fe-core/src/main/java/org/apache/doris/nereids/memo/Memo.java
index 724b91bb97..078ddf72f6 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/nereids/memo/Memo.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/nereids/memo/Memo.java
@@ -451,7 +451,6 @@ public class Memo {
}
GROUP_MERGE_TRACER.log(GroupMergeEvent.of(source, destination,
needReplaceChild));
- Map<Group, Group> needMergeGroupPairs = Maps.newHashMap();
for (GroupExpression reinsertGroupExpr : needReplaceChild) {
// After change GroupExpression children, hashcode will change, so
need to reinsert into map.
groupExpressions.remove(reinsertGroupExpr);
@@ -472,7 +471,7 @@ public class Memo {
reinsertGroupExpr.mergeTo(existGroupExpr);
} else {
// reinsertGroupExpr & existGroupExpr aren't in same
group, need to merge their OwnerGroup.
- needMergeGroupPairs.put(reinsertGroupExpr.getOwnerGroup(),
existGroupExpr.getOwnerGroup());
+ mergeGroup(reinsertGroupExpr.getOwnerGroup(),
existGroupExpr.getOwnerGroup());
}
} else {
groupExpressions.put(reinsertGroupExpr, reinsertGroupExpr);
@@ -483,7 +482,6 @@ public class Memo {
groups.remove(source.getGroupId());
}
- needMergeGroupPairs.forEach(this::mergeGroup);
return destination;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
