AshinGau commented on code in PR #18301:
URL: https://github.com/apache/doris/pull/18301#discussion_r1155063625
##########
be/src/io/fs/hdfs_file_reader.cpp:
##########
@@ -40,6 +40,10 @@ HdfsFileReader::~HdfsFileReader() {
}
Status HdfsFileReader::close() {
+ if (_closed) {
+ return Status::OK();
+ }
+ std::lock_guard<std::mutex> lock(_lock);
Review Comment:
The reader inner `BufferedReader` should be thread safe, otherwise it will
core dump.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
