github-actions[bot] commented on code in PR #18350:
URL: https://github.com/apache/doris/pull/18350#discussion_r1155790678
##########
be/src/vec/functions/like.cpp:
##########
@@ -196,6 +196,39 @@ Status
FunctionLikeBase::constant_substring_fn_scalar(LikeSearchState* state, co
return Status::OK();
}
+Status FunctionLikeBase::constant_re2_regex_fn(LikeSearchState* state, const
ColumnString& val,
+ const StringRef& pattern,
+ ColumnUInt8::Container& result) {
+ auto sz = val.size();
+ for (size_t i = 0; i < sz; i++) {
+ const auto& str_ref = val.get_data_at(i);
+ *(result.data() + i) = RE2::FullMatch(
+ re2::StringPiece(str_ref.data, str_ref.size), *state->regex.get());
Review Comment:
warning: redundant get() call on smart pointer
[readability-redundant-smartptr-get]
```suggestion
re2::StringPiece(str_ref.data, str_ref.size), *state->regex);
```
##########
be/src/vec/functions/like.cpp:
##########
@@ -196,6 +196,39 @@
return Status::OK();
}
+Status FunctionLikeBase::constant_re2_regex_fn(LikeSearchState* state, const
ColumnString& val,
+ const StringRef& pattern,
+ ColumnUInt8::Container& result) {
+ auto sz = val.size();
+ for (size_t i = 0; i < sz; i++) {
+ const auto& str_ref = val.get_data_at(i);
+ *(result.data() + i) = RE2::FullMatch(
+ re2::StringPiece(str_ref.data, str_ref.size), *state->regex.get());
+ }
+
+ return Status::OK();
+}
+
+Status FunctionLikeBase::constant_re2_regex_fn_predicate(LikeSearchState*
state,
+ const
PredicateColumnType<TYPE_STRING>& val,
+ const StringRef& pattern,
+ ColumnUInt8::Container&
result,
+ const uint16_t* sel,
size_t sz) {
+ auto data_ptr = reinterpret_cast<const StringRef*>(val.get_data().data());
+ for (size_t i = 0; i < sz; i++) {
+ *(result.data() + i) = RE2::FullMatch(
+ re2::StringPiece(data_ptr[sel[i]].data, data_ptr[sel[i]].size),
*state->regex.get());
Review Comment:
warning: redundant get() call on smart pointer
[readability-redundant-smartptr-get]
```suggestion
re2::StringPiece(data_ptr[sel[i]].data, data_ptr[sel[i]].size),
*state->regex);
```
##########
be/src/vec/functions/like.cpp:
##########
@@ -196,6 +196,39 @@
return Status::OK();
}
+Status FunctionLikeBase::constant_re2_regex_fn(LikeSearchState* state, const
ColumnString& val,
+ const StringRef& pattern,
+ ColumnUInt8::Container& result) {
+ auto sz = val.size();
+ for (size_t i = 0; i < sz; i++) {
+ const auto& str_ref = val.get_data_at(i);
+ *(result.data() + i) = RE2::FullMatch(
+ re2::StringPiece(str_ref.data, str_ref.size), *state->regex.get());
+ }
+
+ return Status::OK();
+}
+
+Status FunctionLikeBase::constant_re2_regex_fn_predicate(LikeSearchState*
state,
+ const
PredicateColumnType<TYPE_STRING>& val,
+ const StringRef& pattern,
+ ColumnUInt8::Container&
result,
+ const uint16_t* sel,
size_t sz) {
+ auto data_ptr = reinterpret_cast<const StringRef*>(val.get_data().data());
+ for (size_t i = 0; i < sz; i++) {
+ *(result.data() + i) = RE2::FullMatch(
+ re2::StringPiece(data_ptr[sel[i]].data, data_ptr[sel[i]].size),
*state->regex.get());
+ }
+
+ return Status::OK();
+}
+
+Status FunctionLikeBase::constant_re2_regex_fn_scalar(LikeSearchState* state,
const StringRef& val,
+ const StringRef& pattern, unsigned
char* result) {
+ *result = RE2::FullMatch(re2::StringPiece(val.data, val.size),
*state->regex.get());
Review Comment:
warning: redundant get() call on smart pointer
[readability-redundant-smartptr-get]
```suggestion
*result = RE2::FullMatch(re2::StringPiece(val.data, val.size),
*state->regex);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
