xiaokang commented on code in PR #18295:
URL: https://github.com/apache/doris/pull/18295#discussion_r1156653406
##########
be/src/vec/olap/olap_data_convertor.cpp:
##########
@@ -893,28 +893,44 @@ Status
OlapBlockDataConvertor::OlapColumnDataConvertorMap::convert_to_olap(
// offsets data
auto& offsets = column_map->get_offsets();
-
- // Now map column offsets data layout in memory is [3, 6, 9], and in disk
should be [0, 3, 6, 9]
- _offsets.clear();
- _offsets.reserve(offsets.size() + 1);
- _offsets.push_back(
- _base_row); // _offsets must start with current map offsets which
coming blocks in continue pages
- for (auto it = offsets.begin(); it < offsets.end(); ++it) {
- _offsets.push_back(*it + _base_row);
- }
-
int64_t start_index = _row_pos - 1;
int64_t end_index = _row_pos + _num_rows - 1;
- auto start = offsets[start_index];
- auto size = offsets[end_index] - start;
+ auto start_offset = offsets[start_index];
Review Comment:
use column_map->offset_at(_row_pos)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
