HappenLee commented on code in PR #18377:
URL: https://github.com/apache/doris/pull/18377#discussion_r1156837395
##########
be/src/exprs/runtime_filter.cpp:
##########
@@ -1011,6 +1017,11 @@ class RuntimePredicateWrapper {
// When _column_return_type is invalid, _use_batch will be always false.
bool _use_batch;
+
+
+ // When _use_new_hash is set to true, use the new hash method.
+ // This is only to be used if the be_exec_version may be less than 2. If
updated, please delete it.
+ bool _use_new_hash;
Review Comment:
const bool
##########
be/src/vec/exprs/vbloom_predicate.cpp:
##########
@@ -67,10 +67,21 @@ Status VBloomPredicate::execute(VExprContext* context,
Block* block, int* result
auto ptr =
((ColumnVector<UInt8>*)res_data_column.get())->get_data().data();
auto type =
WhichDataType(remove_nullable(block->get_by_position(arguments[0]).type));
if (type.is_string_or_fixed_string()) {
- for (size_t i = 0; i < sz; i++) {
- auto ele = argument_column->get_data_at(i);
- const StringRef v(ele.data, ele.size);
- ptr[i] = _filter->find(reinterpret_cast<const void*>(&v));
+
+ // When _be_exec_version is equal to or greater than 2, we use the new
hash method.
+ // This is only to be used if the be_exec_version may be less than 2.
If updated, please delete it.
+ if(_be_exec_version >= 2){
+ for (size_t i = 0; i < sz; i++) {
+ auto ele = argument_column->get_data_at(i);
+ const StringRef v(ele.data, ele.size);
+ ptr[i] = _filter->find_new_hash(reinterpret_cast<const
void*>(&v));
+ }
+ }else {
Review Comment:
code format
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
