This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new e848e456be [config] modify tablet_shard to 4 and add some log (#18416)
e848e456be is described below
commit e848e456bed57a693cce5d1d0ed9c2d9fb1dd203
Author: Mingyu Chen <[email protected]>
AuthorDate: Thu Apr 6 17:18:16 2023 +0800
[config] modify tablet_shard to 4 and add some log (#18416)
modify the default value of BE config tablet_map_shard_size to 4. To reduce
lock contention.
Add log when failed writing disk test file, for debug
---
be/src/common/config.h | 2 +-
be/src/olap/data_dir.cpp | 3 ++-
be/src/olap/tablet_manager.cpp | 2 +-
docs/en/docs/admin-manual/config/be-config.md | 2 +-
docs/zh-CN/docs/admin-manual/config/be-config.md | 2 +-
5 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/be/src/common/config.h b/be/src/common/config.h
index 63d785b41c..6575a37d13 100644
--- a/be/src/common/config.h
+++ b/be/src/common/config.h
@@ -613,7 +613,7 @@ CONF_mInt64(max_runnings_transactions_per_txn_map, "100");
// tablet_map_lock shard size, the value is 2^n, n=0,1,2,3,4
// this is a an enhancement for better performance to manage tablet
-CONF_Int32(tablet_map_shard_size, "1");
+CONF_Int32(tablet_map_shard_size, "4");
// txn_map_lock shard size, the value is 2^n, n=0,1,2,3,4
// this is a an enhancement for better performance to manage txn
diff --git a/be/src/olap/data_dir.cpp b/be/src/olap/data_dir.cpp
index 3fe2dcd7cc..96c45fc807 100644
--- a/be/src/olap/data_dir.cpp
+++ b/be/src/olap/data_dir.cpp
@@ -225,7 +225,8 @@ void DataDir::health_check() {
if (_is_used) {
Status res = _read_and_write_test_file();
if (!res) {
- LOG(WARNING) << "store read/write test file occur IO Error. path="
<< _path;
+ LOG(WARNING) << "store read/write test file occur IO Error. path="
<< _path
+ << ", err: " << res;
if (res.is_io_error()) {
_is_used = false;
}
diff --git a/be/src/olap/tablet_manager.cpp b/be/src/olap/tablet_manager.cpp
index 0d46ae5f8d..861e34f5ae 100644
--- a/be/src/olap/tablet_manager.cpp
+++ b/be/src/olap/tablet_manager.cpp
@@ -1055,7 +1055,7 @@ void
TabletManager::try_delete_unused_tablet_path(DataDir* data_dir, TTabletId t
TabletMetaSharedPtr tablet_meta(new TabletMeta());
Status check_st = TabletMetaManager::get_meta(data_dir, tablet_id,
schema_hash, tablet_meta);
if (check_st.ok()) {
- LOG(INFO) << "tablet meta exist is meta store, skip delete the path "
<< schema_hash_path;
+ LOG(INFO) << "tablet meta exists in meta store, skip delete the path "
<< schema_hash_path;
return;
}
diff --git a/docs/en/docs/admin-manual/config/be-config.md
b/docs/en/docs/admin-manual/config/be-config.md
index 62091324ac..e61b7eca48 100644
--- a/docs/en/docs/admin-manual/config/be-config.md
+++ b/docs/en/docs/admin-manual/config/be-config.md
@@ -1191,7 +1191,7 @@ Metrics:
{"filtered_rows":0,"input_row_num":3346807,"input_rowsets_count":42,"in
#### `tablet_map_shard_size`
* Description: tablet_map_lock fragment size, the value is 2^n, n=0,1,2,3,4,
this is for better tablet management
-* Default value: 1
+* Default value: 4
#### `tablet_meta_checkpoint_min_interval_secs`
diff --git a/docs/zh-CN/docs/admin-manual/config/be-config.md
b/docs/zh-CN/docs/admin-manual/config/be-config.md
index ac3f47043d..44db0289ee 100644
--- a/docs/zh-CN/docs/admin-manual/config/be-config.md
+++ b/docs/zh-CN/docs/admin-manual/config/be-config.md
@@ -1207,7 +1207,7 @@ Metrics:
{"filtered_rows":0,"input_row_num":3346807,"input_rowsets_count":42,"in
#### `tablet_map_shard_size`
* 描述：tablet_map_lock 分片大小，值为 2^n, n=0,1,2,3,4 ，这是为了更好地管理tablet
-* 默认值：1
+* 默认值：4
#### `tablet_meta_checkpoint_min_interval_secs`
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
