pengxiangyu commented on code in PR #18440:
URL: https://github.com/apache/doris/pull/18440#discussion_r1159700728
##########
be/src/olap/rowset/segment_v2/segment.cpp:
##########
@@ -148,7 +148,10 @@ Status Segment::_parse_footer() {
uint8_t fixed_buf[12];
size_t bytes_read = 0;
- RETURN_IF_ERROR(_file_reader->read_at(file_size - 12, Slice(fixed_buf,
12), &bytes_read));
+ // whole / sub file cache will use it
+ io::IOContext io_ctx;
+ RETURN_IF_ERROR(
+ _file_reader->read_at(file_size - 12, Slice(fixed_buf, 12),
&bytes_read, &io_ctx));
Review Comment:
check io_ctx != nullptr in read_at() is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
