hailin0 commented on PR #18448: URL: https://github.com/apache/doris/pull/18448#issuecomment-1500817253
> Hi @hailin0 Thanks for your contribution. There are some issues: > > 1. We prefer using 4 spaces instead tab for intent, could you please change it? > 2. How to run `extension/beats/doris/doris_integration_test.go`? Please give an example so that I can add it to regression test. > 3. `extension/beats/go.mod ` missing license header, please add it. 1. fixed 2. `doris_integration_test.go` depends on `doris-server` to started, is there any solution? 3. `go.mod` and `go.sum` cannot add file headers，reference [1](https://github.com/apache/dubbo-go/blob/main/go.mod) [2](https://github.com/apache/skywalking-satellite/blob/main/go.mod) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
