github-actions[bot] commented on code in PR #18500:
URL: https://github.com/apache/doris/pull/18500#discussion_r1161288437
##########
be/test/olap/rowset/segment_v2/binary_plain_page_test.cpp:
##########
@@ -72,8 +72,9 @@
vectorized::Arena pool;
size_t size = 3;
std::unique_ptr<ColumnVectorBatch> cvb;
- ColumnVectorBatch::create(size, true,
get_scalar_type_info(OLAP_FIELD_TYPE_VARCHAR),
- nullptr, &cvb);
+ ColumnVectorBatch::create(size, true,
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
ColumnVectorBatch::create(size, true,
^
```
##########
be/test/olap/rowset/segment_v2/binary_dict_page_test.cpp:
##########
@@ -95,7 +95,7 @@
//check values
vectorized::Arena pool;
- auto type_info = get_scalar_type_info(OLAP_FIELD_TYPE_VARCHAR);
+ auto type_info =
get_scalar_type_info(FieldType::OLAP_FIELD_TYPE_VARCHAR);
size_t size = slices.size();
std::unique_ptr<ColumnVectorBatch> cvb;
ColumnVectorBatch::create(size, false, type_info, nullptr, &cvb);
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
ColumnVectorBatch::create(size, false, type_info, nullptr, &cvb);
^
```
##########
be/test/olap/rowset/segment_v2/binary_plain_page_test.cpp:
##########
@@ -88,8 +89,8 @@
EXPECT_EQ("Doris", value[2].to_string());
std::unique_ptr<ColumnVectorBatch> cvb2;
- ColumnVectorBatch::create(1, true,
get_scalar_type_info(OLAP_FIELD_TYPE_VARCHAR), nullptr,
- &cvb2);
+ ColumnVectorBatch::create(1, true,
get_scalar_type_info(FieldType::OLAP_FIELD_TYPE_VARCHAR),
+ nullptr, &cvb2);
ColumnBlock block2(cvb2.get(), &pool);
ColumnBlockView column_block_view2(&block2);
Review Comment:
warning: use of undeclared identifier 'ColumnBlockView'; did you mean
'column_block_view'? [clang-diagnostic-error]
```suggestion
column_block_view column_block_view2(&block2);
```
**be/test/olap/rowset/segment_v2/binary_plain_page_test.cpp:78:**
'column_block_view' declared here
```cpp
ColumnBlockView column_block_view(&block);
^
```
##########
be/test/olap/rowset/segment_v2/binary_prefix_page_test.cpp:
##########
@@ -75,7 +75,7 @@ class BinaryPrefixPageTest : public testing::Test {
//check values
vectorized::Arena pool;
- auto type_info = get_scalar_type_info(OLAP_FIELD_TYPE_VARCHAR);
+ auto type_info =
get_scalar_type_info(FieldType::OLAP_FIELD_TYPE_VARCHAR);
size_t size = slices.size();
std::unique_ptr<ColumnVectorBatch> cvb;
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
std::unique_ptr<ColumnVectorBatch> cvb;
^
```
##########
be/test/olap/rowset/segment_v2/binary_plain_page_test.cpp:
##########
@@ -88,8 +89,8 @@
EXPECT_EQ("Doris", value[2].to_string());
std::unique_ptr<ColumnVectorBatch> cvb2;
- ColumnVectorBatch::create(1, true,
get_scalar_type_info(OLAP_FIELD_TYPE_VARCHAR), nullptr,
- &cvb2);
+ ColumnVectorBatch::create(1, true,
get_scalar_type_info(FieldType::OLAP_FIELD_TYPE_VARCHAR),
+ nullptr, &cvb2);
ColumnBlock block2(cvb2.get(), &pool);
Review Comment:
warning: unknown type name 'ColumnBlock' [clang-diagnostic-error]
```cpp
ColumnBlock block2(cvb2.get(), &pool);
^
```
##########
be/test/olap/rowset/segment_v2/binary_plain_page_test.cpp:
##########
@@ -72,8 +72,9 @@ class BinaryPlainPageTest : public testing::Test {
vectorized::Arena pool;
size_t size = 3;
std::unique_ptr<ColumnVectorBatch> cvb;
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
std::unique_ptr<ColumnVectorBatch> cvb;
^
```
##########
be/test/olap/rowset/segment_v2/binary_plain_page_test.cpp:
##########
@@ -88,8 +89,8 @@
EXPECT_EQ("Doris", value[2].to_string());
std::unique_ptr<ColumnVectorBatch> cvb2;
- ColumnVectorBatch::create(1, true,
get_scalar_type_info(OLAP_FIELD_TYPE_VARCHAR), nullptr,
- &cvb2);
+ ColumnVectorBatch::create(1, true,
get_scalar_type_info(FieldType::OLAP_FIELD_TYPE_VARCHAR),
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
ColumnVectorBatch::create(1, true,
get_scalar_type_info(FieldType::OLAP_FIELD_TYPE_VARCHAR),
^
```
##########
be/test/olap/tablet_schema_helper.cpp:
##########
@@ -24,7 +24,7 @@
TabletColumn column;
column._unique_id = id;
column._col_name = std::to_string(id);
Review Comment:
warning: '_col_name' is a private member of 'doris::TabletColumn'
[clang-diagnostic-error]
```cpp
column._col_name = std::to_string(id);
^
```
**be/src/olap/tablet_schema.h:105:** declared private here
```cpp
std::string _col_name;
^
```
##########
be/test/olap/tablet_schema_helper.cpp:
##########
@@ -24,7 +24,7 @@
TabletColumn column;
column._unique_id = id;
column._col_name = std::to_string(id);
- column._type = OLAP_FIELD_TYPE_INT;
+ column._type = FieldType::OLAP_FIELD_TYPE_INT;
column._is_key = true;
column._is_nullable = is_nullable;
column._length = 4;
Review Comment:
warning: '_length' is a private member of 'doris::TabletColumn'
[clang-diagnostic-error]
```cpp
column._length = 4;
^
```
**be/src/olap/tablet_schema.h:118:** declared private here
```cpp
int32_t _length;
^
```
##########
be/test/olap/tablet_schema_helper.cpp:
##########
@@ -24,7 +24,7 @@
TabletColumn column;
column._unique_id = id;
column._col_name = std::to_string(id);
- column._type = OLAP_FIELD_TYPE_INT;
+ column._type = FieldType::OLAP_FIELD_TYPE_INT;
column._is_key = true;
column._is_nullable = is_nullable;
Review Comment:
warning: '_is_nullable' is a private member of 'doris::TabletColumn'
[clang-diagnostic-error]
```cpp
column._is_nullable = is_nullable;
^
```
**be/src/olap/tablet_schema.h:109:** declared private here
```cpp
bool _is_nullable = false;
^
```
##########
be/test/olap/tablet_schema_helper.cpp:
##########
@@ -24,7 +24,7 @@
TabletColumn column;
column._unique_id = id;
column._col_name = std::to_string(id);
- column._type = OLAP_FIELD_TYPE_INT;
+ column._type = FieldType::OLAP_FIELD_TYPE_INT;
column._is_key = true;
Review Comment:
warning: '_is_key' is a private member of 'doris::TabletColumn'
[clang-diagnostic-error]
```cpp
column._is_key = true;
^
```
**be/src/olap/tablet_schema.h:107:** declared private here
```cpp
bool _is_key = false;
^
```
##########
be/test/olap/rowset/segment_v2/binary_plain_page_test.cpp:
##########
@@ -72,8 +72,9 @@
vectorized::Arena pool;
size_t size = 3;
std::unique_ptr<ColumnVectorBatch> cvb;
- ColumnVectorBatch::create(size, true,
get_scalar_type_info(OLAP_FIELD_TYPE_VARCHAR),
- nullptr, &cvb);
+ ColumnVectorBatch::create(size, true,
+
get_scalar_type_info(FieldType::OLAP_FIELD_TYPE_VARCHAR), nullptr,
+ &cvb);
ColumnBlock block(cvb.get(), &pool);
Review Comment:
warning: unknown type name 'ColumnBlock' [clang-diagnostic-error]
```cpp
ColumnBlock block(cvb.get(), &pool);
^
```
##########
be/test/olap/rowset/segment_v2/binary_dict_page_test.cpp:
##########
@@ -199,7 +200,7 @@
//check values
vectorized::Arena pool;
- auto type_info = get_scalar_type_info(OLAP_FIELD_TYPE_VARCHAR);
+ auto type_info =
get_scalar_type_info(FieldType::OLAP_FIELD_TYPE_VARCHAR);
std::unique_ptr<ColumnVectorBatch> cvb;
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
std::unique_ptr<ColumnVectorBatch> cvb;
^
```
##########
be/test/olap/rowset/segment_v2/binary_plain_page_test.cpp:
##########
@@ -88,8 +89,8 @@
EXPECT_EQ("Doris", value[2].to_string());
std::unique_ptr<ColumnVectorBatch> cvb2;
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
std::unique_ptr<ColumnVectorBatch> cvb2;
^
```
##########
be/test/olap/rowset/segment_v2/binary_dict_page_test.cpp:
##########
@@ -199,7 +200,7 @@
//check values
vectorized::Arena pool;
- auto type_info = get_scalar_type_info(OLAP_FIELD_TYPE_VARCHAR);
+ auto type_info =
get_scalar_type_info(FieldType::OLAP_FIELD_TYPE_VARCHAR);
std::unique_ptr<ColumnVectorBatch> cvb;
ColumnVectorBatch::create(1, false, type_info, nullptr, &cvb);
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
ColumnVectorBatch::create(1, false, type_info, nullptr, &cvb);
^
```
##########
be/test/olap/rowset/segment_v2/binary_dict_page_test.cpp:
##########
@@ -199,7 +200,7 @@
//check values
vectorized::Arena pool;
- auto type_info = get_scalar_type_info(OLAP_FIELD_TYPE_VARCHAR);
+ auto type_info =
get_scalar_type_info(FieldType::OLAP_FIELD_TYPE_VARCHAR);
std::unique_ptr<ColumnVectorBatch> cvb;
ColumnVectorBatch::create(1, false, type_info, nullptr, &cvb);
ColumnBlock column_block(cvb.get(), &pool);
Review Comment:
warning: unknown type name 'ColumnBlock' [clang-diagnostic-error]
```cpp
ColumnBlock column_block(cvb.get(), &pool);
^
```
##########
be/test/olap/rowset/segment_v2/binary_prefix_page_test.cpp:
##########
@@ -75,7 +75,7 @@
//check values
vectorized::Arena pool;
- auto type_info = get_scalar_type_info(OLAP_FIELD_TYPE_VARCHAR);
+ auto type_info =
get_scalar_type_info(FieldType::OLAP_FIELD_TYPE_VARCHAR);
size_t size = slices.size();
std::unique_ptr<ColumnVectorBatch> cvb;
ColumnVectorBatch::create(size, false, type_info, nullptr, &cvb);
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
ColumnVectorBatch::create(size, false, type_info, nullptr, &cvb);
^
```
##########
be/test/olap/rowset/segment_v2/binary_prefix_page_test.cpp:
##########
@@ -96,7 +96,7 @@
while (true) {
//check values
vectorized::Arena pool;
- auto type_info = get_scalar_type_info(OLAP_FIELD_TYPE_VARCHAR);
+ auto type_info =
get_scalar_type_info(FieldType::OLAP_FIELD_TYPE_VARCHAR);
std::unique_ptr<ColumnVectorBatch> cvb;
size_t size = 6;
ColumnVectorBatch::create(size, false, type_info, nullptr, &cvb);
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
ColumnVectorBatch::create(size, false, type_info, nullptr, &cvb);
^
```
##########
be/test/olap/rowset/segment_v2/frame_of_reference_page_test.cpp:
##########
@@ -108,10 +108,11 @@ TEST_F(FrameOfReferencePageTest,
TestInt32BlockEncoderRandom) {
ints.get()[i] = random();
}
- test_encode_decode_page_template<OLAP_FIELD_TYPE_INT,
-
segment_v2::FrameOfReferencePageBuilder<OLAP_FIELD_TYPE_INT>,
-
segment_v2::FrameOfReferencePageDecoder<OLAP_FIELD_TYPE_INT>>(
- ints.get(), size);
+ test_encode_decode_page_template<
Review Comment:
warning: no matching member function for call to
'test_encode_decode_page_template' [clang-diagnostic-error]
```cpp
test_encode_decode_page_template<
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
