Cai-Yao commented on code in PR #18609:
URL: https://github.com/apache/doris/pull/18609#discussion_r1164980618
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SetExecutor.java:
##########
@@ -59,9 +59,24 @@ private void setVariable(SetVar var) throws DdlException {
}
}
+ private boolean isSessionVar(SetVar var) {
+ return !(var instanceof SetPassVar
Review Comment:
> This is error-prone, if other people at a new subclass of `SetVar`, this
method may be missed. How about add a `SetVarType` or something to specify the
stmt's type directly? And write like `return var.setType() ==
Type.SET_SESSION_VAR`;
Yes, I will modify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
