morningman commented on code in PR #18325:
URL: https://github.com/apache/doris/pull/18325#discussion_r1165447270


##########
fe/fe-core/src/main/java/org/apache/doris/load/ExportJob.java:
##########
@@ -714,6 +500,52 @@ public synchronized boolean isFinalState() {
         return this.state == ExportJob.JobState.CANCELLED || this.state == 
ExportJob.JobState.FINISHED;
     }
 
+    public Status makeSnapshots() {

Review Comment:
   ```suggestion
       private Status makeSnapshots() {
   ```



##########
fe/fe-core/src/main/java/org/apache/doris/load/ExportMgr.java:
##########
@@ -86,6 +95,53 @@ private void writeUnlock() {
         lock.writeLock().unlock();
     }
 
+    @Override
+    public synchronized void start() {
+        super.start();
+        exportingExecutor.start();
+    }
+
+    @Override
+    protected void runAfterCatalogReady() {
+        List<ExportJob> pendingJobs = getExportJobs(JobState.PENDING);
+        List<ExportJob> newInQueueJobs = Lists.newArrayList();
+        for (ExportJob job : pendingJobs) {
+            if (handlePendingJobs(job)) {
+                newInQueueJobs.add(job);
+            }
+        }
+        LOG.debug("new IN_QUEUE export job num: {}", newInQueueJobs.size());
+        for (ExportJob job : newInQueueJobs) {
+            try {
+                MasterTask task = new ExportExportingTask(job);
+                if (exportingExecutor.submit(task)) {
+                    LOG.info("success to submit IN_QUEUE export job. job: {}", 
job);
+                } else {
+                    LOG.info("fail to submit IN_QUEUE job to executor. job: 
{}", job);
+
+                }
+            } catch (Exception e) {
+                LOG.warn("run export exporting job error", e);

Review Comment:
   ```suggestion
                   LOG.warn("run export exporting job {}.", job, e);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to