github-actions[bot] commented on code in PR #18635:
URL: https://github.com/apache/doris/pull/18635#discussion_r1166368111
##########
be/src/pipeline/pipeline_task.h:
##########
@@ -174,14 +174,26 @@ class PipelineTask {
std::string debug_string() const;
- uint32_t total_schedule_time() const { return _schedule_time; }
-
taskgroup::TaskGroup* get_task_group() const;
void set_task_queue(TaskQueue* task_queue);
static constexpr auto THREAD_TIME_SLICE = 100'000'000L;
+ // 1 used for update priority queue
+ // note(wb) an ugly implementation, need refactor later
+ // 1.1 pipeline task
+ void inc_runtime_ns(uint64_t delta_time) { this->_runtime += delta_time; }
+ uint64_t get_runtime_ns() { return this->_runtime; }
Review Comment:
warning: method 'get_runtime_ns' can be made const
[readability-make-member-function-const]
```suggestion
uint64_t get_runtime_ns() const { return this->_runtime; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
