TangSiyang2001 commented on code in PR #18421:
URL: https://github.com/apache/doris/pull/18421#discussion_r1168154170
##########
be/src/http/action/download_action.cpp:
##########
@@ -114,6 +126,14 @@ void DownloadAction::handle_error_log(HttpRequest* req,
const std::string& file_
}
void DownloadAction::handle(HttpRequest* req) {
+ if (_is_async) {
Review Comment:
In my opinion, download job for single replica maybe a relatively heavy
task, and it seems that dispatching their process logic to a standalone worker
pool maybe more reasonable, and let free the IO threads to some extent.
Do u think it is reasonable to do so? If so, I'll make some comments to
clarify it, otherwise I'll modify the logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
