yiguolei commented on code in PR #18503:
URL: https://github.com/apache/doris/pull/18503#discussion_r1166258703
##########
be/src/vec/core/block.h:
##########
@@ -264,9 +265,11 @@ class Block {
void append_block_by_selector(MutableBlock* dst, const IColumn::Selector&
selector) const;
+ // need exception safety
static void filter_block_internal(Block* block, const
std::vector<uint32_t>& columns_to_filter,
Review Comment:
it's better to modify this method to be exception safe, and return error
status.
then we only catch exception inside this method. The callers only need to
return_if_error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
