This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git
commit 81e5c6e6a71248132017a8efb7cbf6c0b9b71a85 Author: yiguolei <[email protected]> AuthorDate: Thu Apr 20 15:47:43 2023 +0800 [bugfix](memoryleak) close expr after it is pushdown to storage layer (#18849) Co-authored-by: yiguolei <[email protected]> --- be/src/vec/exec/scan/vscan_node.cpp | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/be/src/vec/exec/scan/vscan_node.cpp b/be/src/vec/exec/scan/vscan_node.cpp index 3ac9d24b2e..63d40d4952 100644 --- a/be/src/vec/exec/scan/vscan_node.cpp +++ b/be/src/vec/exec/scan/vscan_node.cpp @@ -475,6 +475,16 @@ Status VScanNode::_normalize_predicate(VExpr* conjunct_expr_root, VExpr** output *output_expr = conjunct_expr_root; return Status::OK(); } else { + if (left_child == nullptr) { + conjunct_expr_root->children()[0]->close( + _state, *_vconjunct_ctx_ptr, + (*_vconjunct_ctx_ptr)->get_function_state_scope()); + } + if (right_child == nullptr) { + conjunct_expr_root->children()[1]->close( + _state, *_vconjunct_ctx_ptr, + (*_vconjunct_ctx_ptr)->get_function_state_scope()); + } // here only close the and expr self, do not close the child conjunct_expr_root->set_children({}); conjunct_expr_root->close(_state, *_vconjunct_ctx_ptr, --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
