github-actions[bot] commented on code in PR #17542:
URL: https://github.com/apache/doris/pull/17542#discussion_r1174531499
##########
be/src/vec/jsonb/serialize.cpp:
##########
@@ -94,4 +94,86 @@ void JsonbSerializeUtil::jsonb_to_block(const
TupleDescriptor& desc, const char*
}
}
+void JsonbSerializeUtil::jsonb_to_block(TabletSchemaSPtr schema,
+ const std::vector<uint32_t>& col_ids,
+ const ColumnString& jsonb_column,
Block& dst) {
+ for (int i = 0; i < jsonb_column.size(); ++i) {
+ StringRef jsonb_data = jsonb_column.get_data_at(i);
+ jsonb_to_block(schema, col_ids, jsonb_data.data, jsonb_data.size, dst);
+ }
+}
+
+void JsonbSerializeUtil::jsonb_to_block(TabletSchemaSPtr schema,
+ const std::vector<uint32_t>& col_ids,
const char* data,
+ size_t size, Block& dst) {
+ auto pdoc = JsonbDocument::createDocument(data, size);
+ JsonbDocument& doc = *pdoc;
+ for (int j = 0; j < col_ids.size(); ++j) {
+ auto column = schema->column(col_ids[j]);
+ JsonbValue* slot_value = doc->find(column.unique_id());
+ MutableColumnPtr dst_column =
dst.get_by_position(j).column->assume_mutable();
+ if (!slot_value || slot_value->isNull()) {
+ // null or not exist
+ dst_column->insert_default();
+ continue;
+ }
+ // transfer type
+ auto primitive_type = get_primity_type(column.type());
+ deserialize_column(primitive_type, slot_value, dst_column);
Review Comment:
warning: use of undeclared identifier 'deserialize_column'
[clang-diagnostic-error]
```cpp
deserialize_column(primitive_type, slot_value, dst_column);
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
