github-actions[bot] commented on code in PR #18980:
URL: https://github.com/apache/doris/pull/18980#discussion_r1174691569
##########
be/src/runtime/load_channel.h:
##########
@@ -55,8 +55,8 @@ class LoadChannel {
Status open(const PTabletWriterOpenRequest& request);
// this batch must belong to a index in one transaction
- template <typename TabletWriterAddRequest, typename TabletWriterAddResult>
- Status add_batch(const TabletWriterAddRequest& request,
TabletWriterAddResult* response);
+ Status add_batch(const PTabletWriterAddBlockRequest& request,
Review Comment:
warning: unknown type name 'PTabletWriterAddBlockRequest'; did you mean
'PTabletWriterOpenRequest'? [clang-diagnostic-error]
```suggestion
Status add_batch(const PTabletWriterOpenRequest& request,
```
**be/src/runtime/load_channel.h:43:** 'PTabletWriterOpenRequest' declared
here
```cpp
class PTabletWriterOpenRequest;
^
```
##########
be/src/runtime/load_channel.h:
##########
@@ -163,9 +163,8 @@
std::string _sender_ip = "";
};
-template <typename TabletWriterAddRequest, typename TabletWriterAddResult>
-Status LoadChannel::add_batch(const TabletWriterAddRequest& request,
- TabletWriterAddResult* response) {
+Status LoadChannel::add_batch(const PTabletWriterAddBlockRequest& request,
+ PTabletWriterAddBlockResult* response) {
Review Comment:
warning: unknown type name 'PTabletWriterAddBlockResult'
[clang-diagnostic-error]
```cpp
PTabletWriterAddBlockResult* response) {
^
```
##########
be/src/runtime/load_channel_mgr.h:
##########
@@ -136,9 +136,8 @@
return Status::OK();
}
-template <typename TabletWriterAddRequest, typename TabletWriterAddResult>
-Status LoadChannelMgr::add_batch(const TabletWriterAddRequest& request,
- TabletWriterAddResult* response) {
+Status LoadChannelMgr::add_batch(const PTabletWriterAddBlockRequest& request,
+ PTabletWriterAddBlockResult* response) {
Review Comment:
warning: unknown type name 'PTabletWriterAddBlockResult'
[clang-diagnostic-error]
```cpp
PTabletWriterAddBlockResult* response) {
^
```
##########
be/src/runtime/load_channel.h:
##########
@@ -163,9 +163,8 @@
std::string _sender_ip = "";
};
-template <typename TabletWriterAddRequest, typename TabletWriterAddResult>
-Status LoadChannel::add_batch(const TabletWriterAddRequest& request,
- TabletWriterAddResult* response) {
+Status LoadChannel::add_batch(const PTabletWriterAddBlockRequest& request,
+ PTabletWriterAddBlockResult* response) {
int64_t index_id = request.index_id();
Review Comment:
warning: member access into incomplete type 'const
doris::PTabletWriterOpenRequest' [clang-diagnostic-error]
```cpp
int64_t index_id = request.index_id();
^
```
**be/src/runtime/tablets_channel.h:54:** forward declaration of
'doris::PTabletWriterOpenRequest'
```cpp
class PTabletWriterOpenRequest;
^
```
##########
be/src/runtime/tablets_channel.h:
##########
@@ -87,8 +87,8 @@
Status open(const PTabletWriterOpenRequest& request);
// no-op when this channel has been closed or cancelled
- template <typename TabletWriterAddRequest, typename TabletWriterAddResult>
- Status add_batch(const TabletWriterAddRequest& request,
TabletWriterAddResult* response);
+ Status add_batch(const PTabletWriterAddBlockRequest& request,
+ PTabletWriterAddBlockResult* response);
Review Comment:
warning: unknown type name 'PTabletWriterAddBlockResult'
[clang-diagnostic-error]
```cpp
PTabletWriterAddBlockResult* response);
^
```
##########
be/src/runtime/tablets_channel.h:
##########
@@ -87,8 +87,8 @@ class TabletsChannel {
Status open(const PTabletWriterOpenRequest& request);
// no-op when this channel has been closed or cancelled
- template <typename TabletWriterAddRequest, typename TabletWriterAddResult>
- Status add_batch(const TabletWriterAddRequest& request,
TabletWriterAddResult* response);
+ Status add_batch(const PTabletWriterAddBlockRequest& request,
Review Comment:
warning: unknown type name 'PTabletWriterAddBlockRequest'; did you mean
'PTabletWriterOpenRequest'? [clang-diagnostic-error]
```suggestion
Status add_batch(const PTabletWriterOpenRequest& request,
```
**be/src/runtime/tablets_channel.h:54:** 'PTabletWriterOpenRequest' declared
here
```cpp
class PTabletWriterOpenRequest;
^
```
##########
be/src/runtime/tablets_channel.cpp:
##########
@@ -309,9 +309,8 @@ std::ostream& operator<<(std::ostream& os, const
TabletsChannelKey& key) {
return os;
}
-template <typename TabletWriterAddRequest, typename TabletWriterAddResult>
-Status TabletsChannel::add_batch(const TabletWriterAddRequest& request,
- TabletWriterAddResult* response) {
+Status TabletsChannel::add_batch(const PTabletWriterAddBlockRequest& request,
Review Comment:
warning: out-of-line definition of 'add_batch' does not match any
declaration in 'doris::TabletsChannel' [clang-diagnostic-error]
```cpp
Status TabletsChannel::add_batch(const PTabletWriterAddBlockRequest& request,
^
```
##########
be/src/runtime/load_channel_mgr.h:
##########
@@ -54,8 +54,8 @@
// open a new load channel if not exist
Status open(const PTabletWriterOpenRequest& request);
- template <typename TabletWriterAddRequest, typename TabletWriterAddResult>
- Status add_batch(const TabletWriterAddRequest& request,
TabletWriterAddResult* response);
+ Status add_batch(const PTabletWriterAddBlockRequest& request,
+ PTabletWriterAddBlockResult* response);
Review Comment:
warning: unknown type name 'PTabletWriterAddBlockResult'
[clang-diagnostic-error]
```cpp
PTabletWriterAddBlockResult* response);
^
```
##########
be/src/runtime/load_channel.h:
##########
@@ -55,8 +55,8 @@
Status open(const PTabletWriterOpenRequest& request);
// this batch must belong to a index in one transaction
- template <typename TabletWriterAddRequest, typename TabletWriterAddResult>
- Status add_batch(const TabletWriterAddRequest& request,
TabletWriterAddResult* response);
+ Status add_batch(const PTabletWriterAddBlockRequest& request,
+ PTabletWriterAddBlockResult* response);
Review Comment:
warning: unknown type name 'PTabletWriterAddBlockResult'
[clang-diagnostic-error]
```cpp
PTabletWriterAddBlockResult* response);
^
```
##########
be/src/runtime/load_channel_mgr.h:
##########
@@ -54,8 +54,8 @@ class LoadChannelMgr {
// open a new load channel if not exist
Status open(const PTabletWriterOpenRequest& request);
- template <typename TabletWriterAddRequest, typename TabletWriterAddResult>
- Status add_batch(const TabletWriterAddRequest& request,
TabletWriterAddResult* response);
+ Status add_batch(const PTabletWriterAddBlockRequest& request,
Review Comment:
warning: unknown type name 'PTabletWriterAddBlockRequest'
[clang-diagnostic-error]
```cpp
Status add_batch(const PTabletWriterAddBlockRequest& request,
^
```
##########
be/src/runtime/load_channel.h:
##########
@@ -163,9 +163,8 @@
std::string _sender_ip = "";
};
-template <typename TabletWriterAddRequest, typename TabletWriterAddResult>
-Status LoadChannel::add_batch(const TabletWriterAddRequest& request,
- TabletWriterAddResult* response) {
+Status LoadChannel::add_batch(const PTabletWriterAddBlockRequest& request,
Review Comment:
warning: unknown type name 'PTabletWriterAddBlockRequest'; did you mean
'PTabletWriterOpenRequest'? [clang-diagnostic-error]
```suggestion
Status LoadChannel::add_batch(const PTabletWriterOpenRequest& request,
```
**be/src/runtime/load_channel.h:43:** 'PTabletWriterOpenRequest' declared
here
```cpp
class PTabletWriterOpenRequest;
^
```
##########
be/src/runtime/load_channel_mgr.h:
##########
@@ -136,9 +136,8 @@
return Status::OK();
}
-template <typename TabletWriterAddRequest, typename TabletWriterAddResult>
-Status LoadChannelMgr::add_batch(const TabletWriterAddRequest& request,
- TabletWriterAddResult* response) {
+Status LoadChannelMgr::add_batch(const PTabletWriterAddBlockRequest& request,
Review Comment:
warning: unknown type name 'PTabletWriterAddBlockRequest'
[clang-diagnostic-error]
```cpp
Status LoadChannelMgr::add_batch(const PTabletWriterAddBlockRequest& request,
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
