morningman commented on PR #18712: URL: https://github.com/apache/doris/pull/18712#issuecomment-1519226862
> > > > > > > NullPointerException is not a good exception, better to avoid it. > > > > > > > > > If tOperationStatus is null, it will enter the conditional branch. If it enters the conditional branch, the subsequent tOperationStatus.getMessage() method will throw a NullPointerException. > > > > > > What I mean is, after your modification, if `tOperationStatus` is null, it may throw NPE. But it is not a good idea to throw NPE. > > I think we should separately check if `tOperationStatus` is null. What do you think? looks good to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
