On Thu, 06 Feb 2014 14:37:26 +0100, John Marino <[email protected]> wrote:

Finally, several functions were turned into static functions and explicit
    void casts were used when functions normally return integers.

I don't really see the point in bringing in the (void) casts. We explicitly removed them back in 2004/2005 for large parts of base when it was agreed that they are just eyesores mostly, and - since we do not put them in new code we write, either - the best we can achieve is an inconsistent mix.

Stylistic changes such as those only make sense (IMO) when we can hope for consistency and/or check for it or enforce it somehow.

Sascha

Reply via email to