Thanks for the explanation. As you said we don't have the issue that this commit is intended to fix, I'd revert the whole commit, OK?
On Thu, 9 Aug 2018 09:05:18 +0800 Sepherosa Ziehau <sepher...@gmail.com> wrote: > Please backout the "simplify the ifnet_unlock" part. The original > protection range is used to make sure that the ifp does not get ripped > out behind our back. To be frank, we don't even suffer the issue this > fix is intended to address; it only makes the code convoluted. > > On Wed, Aug 8, 2018 at 5:10 PM, Aaron LI <a...@crater.dragonflybsd.org> > wrote: > > > > commit 0a887f91f9633448c99b9a5b7c6116a0a22d25d6 > > Author: Aaron LI <a...@aaronly.me> > > Date: Sat Jun 16 23:18:20 2018 +0800 > > > > pf: Allow disappearing or not yet existing interfaces for ALTQ > > > > Make ALTQ cope with disappearing interfaces (particularly common with > > net/mpd4 and netgraph in general). This also allows to add queues for > > an interface that is not yet existing, however, you have to provide > > the bandwidth for the interface. > > > > Meanwhile, simplify the ifnet_unlock() calls for ifunit() use. > > > > Taken-from: FreeBSD (r177700) > > > > Summary of changes: > > sys/net/pf/pf_if.c | 10 ++++ > > sys/net/pf/pf_ioctl.c | 123 > > +++++++++++++++++++++++++++++++++++------- sys/net/pf/pfvar.h > > | 6 +++ usr.sbin/pfctl/pfctl_altq.c | 4 ++ > > usr.sbin/pfctl/pfctl_qstats.c | 17 +++++- > > 5 files changed, 139 insertions(+), 21 deletions(-) > > > > http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/0a887f91f9633448c99b9a5b7c6116a0a22d25d6 > > > > > > -- > > DragonFly BSD source repository
pgpTGQ8Bbykwp.pgp
Description: OpenPGP digital signature