Repository: drill Updated Branches: refs/heads/master 13f21e14b -> 4ee1d4c77
DRILL-4950: Remove incorrect false condition; consume all empty batches closes #621 Project: http://git-wip-us.apache.org/repos/asf/drill/repo Commit: http://git-wip-us.apache.org/repos/asf/drill/commit/6d2b9481 Tree: http://git-wip-us.apache.org/repos/asf/drill/tree/6d2b9481 Diff: http://git-wip-us.apache.org/repos/asf/drill/diff/6d2b9481 Branch: refs/heads/master Commit: 6d2b948120e799bc27c1593baf8df81f6f30f94b Parents: 13f21e1 Author: Sudheesh Katkam <[email protected]> Authored: Tue Oct 18 14:22:53 2016 -0700 Committer: Aman Sinha <[email protected]> Committed: Thu Oct 20 21:58:56 2016 -0700 ---------------------------------------------------------------------- .../java/org/apache/drill/jdbc/impl/DrillCursor.java | 13 ------------- 1 file changed, 13 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/drill/blob/6d2b9481/exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java ---------------------------------------------------------------------- diff --git a/exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java b/exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java index a19f82a..08570a8 100644 --- a/exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java +++ b/exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java @@ -185,19 +185,6 @@ class DrillCursor implements Cursor { qrb.release(); qrb = resultsListener.getNext(); - - // NOTE: It is unclear why this check does not check getRowCount() - // as the loop condition above does. - if ( qrb != null && qrb.getData() == null ) { - // Got another batch with null data--dispose of and report "no more - // rows". - - qrb.release(); - - // NOTE: It is unclear why this returns false but doesn't set - // afterLastRow (as we do when we normally return false). - return false; - } } }
