This is an automated email from the ASF dual-hosted git repository.

cgivre pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/drill.git


The following commit(s) were added to refs/heads/master by this push:
     new 239a8f8  [MINOR UPDATE] Remove bogus copy pasta test of log dir env 
var. (#2434)
239a8f8 is described below

commit 239a8f8336936ac51707fbf4a73da86a1156cd59
Author: James Turton <[email protected]>
AuthorDate: Wed Jan 26 17:27:50 2022 +0200

    [MINOR UPDATE] Remove bogus copy pasta test of log dir env var. (#2434)
    
    The removed test is a copy pasta of the log dir test so does not test
    the native lib dir variables it claims to at all.  There is a legitimate
    test of the native lib dir env vars present in the same test class.
---
 .../org/apache/drill/yarn/scripts/TestScripts.java | 28 ----------------------
 1 file changed, 28 deletions(-)

diff --git 
a/drill-yarn/src/test/java/org/apache/drill/yarn/scripts/TestScripts.java 
b/drill-yarn/src/test/java/org/apache/drill/yarn/scripts/TestScripts.java
index 8422c62..6bb800b 100644
--- a/drill-yarn/src/test/java/org/apache/drill/yarn/scripts/TestScripts.java
+++ b/drill-yarn/src/test/java/org/apache/drill/yarn/scripts/TestScripts.java
@@ -273,34 +273,6 @@ public class TestScripts extends BaseTest {
   }
 
   /**
-   * Create a custom Java lib path. This uses the new DRILL_JAVA_LIB_PATH
-   * variable.
-   */
-
-  @Test
-  public void testLibPath() throws IOException {
-    context.createMockDistrib();
-    File siteDir = new File(context.testDrillHome, "conf");
-    context.createMockConf(siteDir);
-    File logsDir = context.createDir(new File(context.testDir, "logs"));
-    context.removeDir(new File(context.testDrillHome, "log"));
-
-    {
-      String logPath = logsDir.getAbsolutePath();
-      RunResult result = new DrillbitRun(DrillbitRun.DRILLBIT_RUN)
-          .addEnv("DRILL_LOG_DIR", logPath).withLogDir(logsDir).run();
-      assertEquals(0, result.returnCode);
-      result.validateArgs(
-          new String[] { "-Dlog.path=" + logPath + "/drillbit.log",
-              "-Dlog.query.path=" + logPath + "/drillbit_queries.json", });
-      result.validateStdOut();
-      result.validateStdErr();
-      result.validateDrillLog();
-    }
-
-  }
-
-  /**
    * Try setting custom environment variable values in drill-env.sh in the
    * $DRILL_HOME/conf location.
    */

Reply via email to