jihoonson commented on a change in pull request #5958: Part 2 of changes for
SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r205893700
##########
File path:
processing/src/main/java/io/druid/query/aggregation/AggregatorUtil.java
##########
@@ -168,7 +168,7 @@ public static BaseFloatColumnValueSelector
makeColumnValueSelectorWithFloatDefau
public float getFloat()
{
final ExprEval exprEval = baseSelector.getObject();
- return exprEval.isNull() ? nullValue : (float) exprEval.asDouble();
+ return exprEval.isNumericNull() ? nullValue : (float)
exprEval.asDouble();
Review comment:
Ah, I just saw the return value of
`BaseObjectColumnValueSelector.getObject()` is nullable. Looks that it's not in
this case. Please add a comment about this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
