jihoonson commented on issue #6090: Fix missing exception handling as part of `io.druid.java.util.http.client.netty.HttpClientPipelineFactory` URL: https://github.com/apache/incubator-druid/pull/6090#issuecomment-410076531 Hi @asdf2014, I've looked into this more and found something. We already have a [handler](https://github.com/apache/incubator-druid/blob/master/java-util/src/main/java/io/druid/java/util/http/client/NettyHttpClient.java#L182-L321) to handle the exception. The reason why the log in https://github.com/apache/incubator-druid/issues/6024 is printed is this handler is removed before the channel is closed. So, [these changes](https://github.com/apache/incubator-druid/compare/master...jihoonson:fix-netty-client?expand=1) would be enough.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
