gianm commented on a change in pull request #6107: Order rows during
incremental index persist when rollup is disabled.
URL: https://github.com/apache/incubator-druid/pull/6107#discussion_r207743167
##########
File path:
processing/src/main/java/io/druid/segment/incremental/IncrementalIndex.java
##########
@@ -1379,10 +1407,31 @@ public long getMaxTimeMillis()
);
}
+ private Stream<IncrementalIndexRow> timeAndDimsOrderedConcat(
+ final Collection<Deque<IncrementalIndexRow>> rowGroups,
+ final boolean descending
+ )
+ {
+ if (descending) {
Review comment:
The descending code path is never used, so please remove it. I think in
general we want to avoid unused code, since it can confuse readers, and it can
have 'sleeper' bugs that awake if someone ever tries to use the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
