gianm commented on a change in pull request #6109: update redis-cache 
documentation
URL: https://github.com/apache/incubator-druid/pull/6109#discussion_r207746697
 
 

 ##########
 File path: docs/content/development/extensions-contrib/redis-cache.md
 ##########
 @@ -8,9 +8,14 @@ Druid Redis Cache
 A cache implementation for Druid based on 
[Redis](https://github.com/antirez/redis).
 
 # Configuration
-Below are the configuration options known to this module:
+Below are the configuration options known to this module.
 
-|`runtime.properties`|Description|Default|Required|
+Note that just adding these properties does not enable the cache. You still 
need to add the `druid.<nodetype>.cache.useCache` and 
`druid.<nodetype>.cache.populateCache` properties for the nodes you want to 
enable the cache on.
 
 Review comment:
   Something in here should ideally link to `../../configuration/caching.html`, 
where the properties are discussed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to