asdf2014 commented on a change in pull request #6090: Fix missing exception
handling as part of
`io.druid.java.util.http.client.netty.HttpClientPipelineFactory`
URL: https://github.com/apache/incubator-druid/pull/6090#discussion_r208481301
##########
File path:
java-util/src/main/java/io/druid/java/util/http/client/pool/ChannelResourceFactory.java
##########
@@ -109,6 +112,28 @@ public ChannelFuture generate(final String hostname)
final ChannelPipeline pipeline =
connectFuture.getChannel().getPipeline();
pipeline.addFirst("ssl", sslHandler);
+ pipeline.addLast("connectionErrorHandler", new
SimpleChannelUpstreamHandler()
Review comment:
Hi, @jihoonson . What you mean is that we should use the following code to
ensure that the order of those handlers is `SSL handler + Error handler +
Others handlers`?
```java
pipeline.addFirst("connectionErrorHandler", new
SimpleChannelUpstreamHandler(){...})
pipeline.addFirst("ssl", sslHandler);
```
IMO, maybe the current order is fine, the `Error handler` should be placed
at the end of the pipeline, so that the order of the handlers will be `SSL
handler + Others handlers + Error handler`. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
