jon-wei commented on a change in pull request #6119: Add docs for virtual columns and transform specs URL: https://github.com/apache/incubator-druid/pull/6119#discussion_r208758211
########## File path: docs/content/ingestion/index.md ########## @@ -244,6 +246,9 @@ for the `comment` column. } ``` +## metricsSpec + The `metricsSpec` is a list of [aggregators](../querying/aggregations.html). If `rollup` is false in the granularity spec, the metrics spec can be an empty list and all columns can be defined in the dimensionsSpec instead. Review comment: It's optional, but "more proper" to put it in the `dimensionSpec` (since with no rollup there's not a real concept of 'metric'). Going forward, I think we should re-do how the ingestion specs are represented so the rollup case -> define dimensions/metrics, no rollup -> define columns ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
