jihoonson commented on a change in pull request #6155: Fix three bugs with
segment publishing.
URL: https://github.com/apache/incubator-druid/pull/6155#discussion_r209740211
##########
File path:
server/src/main/java/io/druid/metadata/IndexerSQLMetadataStorageCoordinator.java
##########
@@ -359,9 +362,10 @@ public SegmentPublishResult inTransaction(
);
}
catch (CallbackFailedException e) {
- if (txnFailure.get()) {
- return new SegmentPublishResult(ImmutableSet.of(), false);
+ if (definitelyNotUpdated.get()) {
+ return SegmentPublishResult.fail();
Review comment:
What do you think about adding an exception to `SegmentPublishResult` on
failure, so that callers can figure out why it failed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
