gianm commented on a change in pull request #6155: Fix three bugs with segment
publishing.
URL: https://github.com/apache/incubator-druid/pull/6155#discussion_r210139396
##########
File path:
server/src/main/java/io/druid/metadata/IndexerSQLMetadataStorageCoordinator.java
##########
@@ -359,9 +362,10 @@ public SegmentPublishResult inTransaction(
);
}
catch (CallbackFailedException e) {
- if (txnFailure.get()) {
- return new SegmentPublishResult(ImmutableSet.of(), false);
+ if (definitelyNotUpdated.get()) {
+ return SegmentPublishResult.fail();
Review comment:
I think it's not necessary, since there is supposed to be only one reason:
compare-and-swap failure with the metadata update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
